Skip to content

Comments

WA-NEW-005: Remove unsupported use_dis_max from query_string queries (ES7)#649

Open
kitcommerce wants to merge 5 commits intonextfrom
wa-new-005-remove-use-dis-max
Open

WA-NEW-005: Remove unsupported use_dis_max from query_string queries (ES7)#649
kitcommerce wants to merge 5 commits intonextfrom
wa-new-005-remove-use-dis-max

Conversation

@kitcommerce
Copy link

Closes #645.\n\nExtracted from stacked PRs #630/#631 to make merge order linear.

Jason Hill added 5 commits February 20, 2026 14:17
…(ES7)

The use_dis_max parameter was removed from the Elasticsearch query_string
query in ES7. It caused a 400 parsing_exception:
  [query_string] query does not support [use_dis_max]

In ES7 the equivalent behavior is achieved via tie_breaker (default 0.0
gives pure dis_max scoring). Where tie_breaker was already present (product
search) only use_dis_max was removed; where it was absent (admin index search,
help search) removing the flag restores the ES7 default (tie_breaker=0).

Files changed:
- core/app/queries/workarea/search/admin_index_search.rb
- core/app/queries/workarea/search/help_search.rb
- core/app/queries/workarea/search/product_search.rb
@kitcommerce kitcommerce force-pushed the wa-new-005-remove-use-dis-max branch from d22d283 to 021eecd Compare February 20, 2026 19:17
@kitcommerce kitcommerce added gate:build-pending Build gate in progress gate:build-passed Build gate passed and removed build:failed gate:build-pending Build gate in progress labels Feb 20, 2026
@kitcommerce
Copy link
Author

Dispatcher Build Gate Summary (local)

  • rubocop (diff-only): PASS (0 offenses)
  • brakeman: skipped (per repo build gate config; disabled)
  • tests (affected engines): PASS
    • core: PASS
    • admin: PASS
    • storefront: PASS

Note: test output still prints BSON Symbol deprecation warning (expected to be addressed by WA-NEW-010 / PR #635).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gate:build-passed Build gate passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant